* Refactor a couple of iterators
* Use side-effect instead of second iterator
* Make World::onTick return shouldDelete instead of success
* Replace Shop iterator with side effects
* Scene
* Clean up Expeditions
* Refactor Expeditions
* Clean up Expeditions, Player
* Limit Expeditions by AR
* Lombokify props
Co-authored-by: AnimeGitB <AnimeGitB@bigblueball.in>
## Description
Removed auto generation of Handbook since with the new versions GC won't exit when finished generating it, so the script was stuck, and for some reason if you stop GC manually, the script won't continue.
Added a recommendation to generate HB manually.
## Type of changes
- [x] Bug fix
- [ ] New feature
- [x] Enhancement
- [ ] Documentation
## Checklist:
- [x] My code follows the style guidelines of this project
- [x] My pull request is unique and no other pull requests have been opened for these changes
- [x] I have read the [Contributing note](https://github.com/Grasscutters/Grasscutter/blob/stable/CONTRIBUTING.md) and [Code of conduct](https://github.com/Grasscutters/Grasscutter/blob/development/CODE_OF_CONDUCT.md)
- [x] I am responsible for any copyright issues with my code if it occurs in the future.
Original commits:
* Add necessary protos for scene point/area unlocking.
* Rename PlayerOpenStateManager to PlayerProgressManager and move data to Player.
* Handle unlocking of waypoints.
* Add primo rewards for waypoint unlock.
* Statue unlocking.
* Add statue quest on player login.
* I forgor to add an unlock command.
* Give EXP as reward, fire quest trigger, make EXP UI show up.
Original commits:
* Clean-up
* Introduce a new application arguments parser & handler
* Clean-up and deprecate `Tools#getLanguageOption`
* Fix `-debug` and `-debugall` parameters
* found this while debugging, ...why
* Remove deprecated parameters
* Invoke startup argument parser before handbook generation
* Move command map instantiation to `Grasscutter `(prevent making 3 instances on startup)
* Ensure \n at EOF
Co-authored-by: AnimeGitB <AnimeGitB@bigblueball.in>
AnimeGitB
1chanuser
GanyusLeftHorn
2y8e9h22
Luke H-W
Zxilly
Magix
dragon
dragon
RBNXI
KingRainbow44
hmdnnrmn